Skip to content

Commit

Permalink
fix: remove default resolution strategy values from GCM fields
Browse files Browse the repository at this point in the history
  • Loading branch information
@bardisg
bardisg committed Jan 26, 2024
1 parent 3e975e2 commit 33127d7
Show file tree
Hide file tree
Showing 12 changed files with 118 additions and 96 deletions.
30 changes: 10 additions & 20 deletions src/configurations/destinations/customerio/schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -191,8 +190,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -238,8 +236,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -285,8 +282,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -332,8 +328,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -379,8 +374,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -426,8 +420,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -473,8 +466,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -520,8 +512,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -567,8 +558,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down
4 changes: 3 additions & 1 deletion src/configurations/destinations/customerio/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@
"label": "the required consent logic",
"configKey": "resolutionStrategy",
"options": [
{
"label": ""
},
{
"label": "AND",
"value": "and"
Expand All @@ -337,7 +340,6 @@
"value": "or"
}
],
"default": "and",
"required": true,
"variant": "badge",
"preRequisites": {
Expand Down
27 changes: 9 additions & 18 deletions src/configurations/destinations/ga4/schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -169,8 +168,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -216,8 +214,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -263,8 +260,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -310,8 +306,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -357,8 +352,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -404,8 +398,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -451,8 +444,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -498,8 +490,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down
4 changes: 3 additions & 1 deletion src/configurations/destinations/ga4/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,9 @@
"label": "the required consent logic",
"configKey": "resolutionStrategy",
"options": [
{
"label": ""
},
{
"label": "AND",
"value": "and"
Expand All @@ -438,7 +441,6 @@
"value": "or"
}
],
"default": "and",
"required": true,
"variant": "badge",
"preRequisites": {
Expand Down
27 changes: 9 additions & 18 deletions src/configurations/destinations/mp/schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -309,8 +308,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -356,8 +354,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -403,8 +400,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -450,8 +446,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -497,8 +492,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -544,8 +538,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -591,8 +584,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down Expand Up @@ -638,8 +630,7 @@
"properties": {
"resolutionStrategy": {
"type": "string",
"enum": ["and", "or"],
"default": "and"
"enum": ["and", "or"]
}
},
"required": ["resolutionStrategy"]
Expand Down
7 changes: 3 additions & 4 deletions src/configurations/destinations/mp/ui-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,9 @@
"label": "the required consent logic",
"value": "resolutionStrategy",
"options": [
{
"label": ""
},
{
"name": "AND",
"value": "and"
Expand All @@ -507,10 +510,6 @@
"value": "or"
}
],
"defaultOption": {
"name": "AND",
"value": "and"
},
"required": true,
"variant": "badge",
"preRequisites": {
Expand Down
Loading

0 comments on commit 33127d7

Please sign in to comment.