Merge pull request #1902 from rudderlabs/fix.gaoc

fix: remove unused config from gaoc
rudderlabs · Mar 3, 2025 · 8bb0f3c · 8bb0f3c
1 parent 95870de
commit 8bb0f3c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 91 deletions.
diff --git a/src/configurations/destinations/google_adwords_offline_conversions/db-config.json b/src/configurations/destinations/google_adwords_offline_conversions/db-config.json
@@ -54,9 +54,7 @@
         "conversionEnvironment",
         "defaultUserIdentifier",
         "hashUserIdentifier",
-        "validateOnly",
-        "personalizationConsent",
-        "userDataConsent"
+        "validateOnly"
       ],
       "android": [
         "connectionMode",

diff --git a/src/configurations/destinations/google_adwords_offline_conversions/schema.json b/src/configurations/destinations/google_adwords_offline_conversions/schema.json
@@ -44,16 +44,6 @@
           }
         }
       },
-      "userDataConsent": {
-        "type": "string",
-        "enum": ["UNSPECIFIED", "UNKNOWN", "GRANTED", "DENIED"],
-        "default": "UNSPECIFIED"
-      },
-      "personalizationConsent": {
-        "type": "string",
-        "enum": ["UNSPECIFIED", "UNKNOWN", "GRANTED", "DENIED"],
-        "default": "UNSPECIFIED"
-      },
       "customVariables": {
         "type": "array",
         "items": {

diff --git a/src/configurations/destinations/google_adwords_offline_conversions/ui-config.json b/src/configurations/destinations/google_adwords_offline_conversions/ui-config.json
@@ -74,72 +74,6 @@
           "placeholderRight": "e.g: App Sign-up",
           "value": "eventsToConversionsNamesMapping"
         },
-        {
-          "type": "singleSelect",
-          "label": "Specify the consent for uploaded users for using their data in Google Advertising Purpose",
-          "footerNote": "For store sales this is the only way to provide consent for using the data for Google Advertising. ref: https://developers.google.com/google-ads/api/rest/reference/rest/v16/Consent",
-          "value": "userDataConsent",
-          "options": [
-            {
-              "name": "Unspecified",
-              "value": "UNSPECIFIED"
-            },
-            {
-              "name": "Unknown",
-              "value": "UNKNOWN"
-            },
-            {
-              "name": "Granted",
-              "value": "GRANTED"
-            },
-            {
-              "name": "Denied",
-              "value": "DENIED"
-            }
-          ],
-          "default": "UNSPECIFIED",
-          "preRequisites": {
-            "featureFlags": [
-              {
-                "configKey": "AMP_gaoc_enable_consent_mode",
-                "value": true
-              }
-            ]
-          }
-        },
-        {
-          "type": "singleSelect",
-          "label": "Specify the consent for uploaded users for using their data regarding Ads Personalization",
-          "footerNote": "For store sales this is the only way to provide consent for using the data for Google Ads Personalization. Ref: https://developers.google.com/google-ads/api/rest/reference/rest/v16/Consent",
-          "value": "personalizationConsent",
-          "options": [
-            {
-              "name": "Unspecified",
-              "value": "UNSPECIFIED"
-            },
-            {
-              "name": "Unknown",
-              "value": "UNKNOWN"
-            },
-            {
-              "name": "Granted",
-              "value": "GRANTED"
-            },
-            {
-              "name": "Denied",
-              "value": "DENIED"
-            }
-          ],
-          "default": "UNSPECIFIED",
-          "preRequisites": {
-            "featureFlags": [
-              {
-                "configKey": "AMP_gaoc_enable_consent_mode",
-                "value": true
-              }
-            ]
-          }
-        },
         {
           "type": "dynamicForm",
           "label": "Map your variable names to custom Google Ads variables.",

diff --git a/test/data/validation/destinations/google_adwords_offline_conversions.json b/test/data/validation/destinations/google_adwords_offline_conversions.json
@@ -20,8 +20,6 @@
           "to": "call"
         }
       ],
-      "userDataConsent": "GRANTED",
-      "personalizationConsent": "GRANTED",
       "eventsToConversionsNamesMapping": [
         {
           "from": "Sign up completed",
@@ -66,8 +64,6 @@
           "to": "call"
         }
       ],
-      "userDataConsent": "RANDOM",
-      "personalizationConsent": "GRANTED",
       "eventsToConversionsNamesMapping": [
         {
           "from": "Sign up completed",
@@ -89,8 +85,7 @@
         }
       ]
     },
-    "result": false,
-    "err": ["userDataConsent must be equal to one of the allowed values"]
+    "result": true
   },
   {
     "config": {
@@ -113,8 +108,6 @@
           "to": "call"
         }
       ],
-      "userDataConsent": "GRANTED",
-      "personalizationConsent": "GRANTED",
       "eventsToConversionsNamesMapping": [
         {
           "from": "Sign up completed",
@@ -281,8 +274,6 @@
           "to": "call"
         }
       ],
-      "userDataConsent": "GRANTED",
-      "personalizationConsent": "GRANTED",
       "eventsToConversionsNamesMapping": [
         {
           "from": "Sign up completed",
@@ -344,8 +335,6 @@
           "to": "call"
         }
       ],
-      "userDataConsent": "GRANTED",
-      "personalizationConsent": "GRANTED",
       "eventsToConversionsNamesMapping": [
         {
           "from": "Sign up completed",