Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move google ads to new ui #1055

Closed
wants to merge 28 commits into from
Closed

feat: move google ads to new ui #1055

wants to merge 28 commits into from

Conversation

mihir-4116
Copy link
Contributor

@mihir-4116 mihir-4116 commented Nov 7, 2023 •
edited
Loading

Description of the change

Screenshots :

  • Initial Setup
image
  • Configuration Settings
image
  • Other Settings
image
  • Event mapping section
image
  • Conversion events mapping section
image
  • Dynamic remarketing events mapping section
image

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mihir-4116 mihir-4116 changed the title feat: move google ads to new ui feat(INT-849): move google ads to new ui Nov 7, 2023
@linear Linear
Copy link

linear bot commented Nov 7, 2023

INT-849 Google Ads configs are pretty unclear - bit over complicated and unclear

Slack thread: https://rudderlabs.slack.com/archives/C02A3UAU9UN/p1697469139701119?thread_ts=1697464846.523199&cid=C02A3UAU9UN
Message by: david
Feature Request by: Shreya Yaduvanshi
thread_id=<1697469139.701119>
channel_id=

@mihir-4116 mihir-4116 changed the title feat(INT-849): move google ads to new ui feat: move google ads to new ui Nov 7, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0a8d1f) 100.00% compared to head (9a4638a) 100.00%.
Report is 38 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop     #1055   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krishna2020
krishna2020 reviewed Nov 13, 2023
View reviewed changes
src/configurations/destinations/googleads/db-config.json
@@ -29,17 +27,18 @@
"enableConversionLabel"
],
"excludeKeys": [],
"supportedConnectionModes": {
"web": ["device"]
},
"supportedSourceTypes": ["web"],
"destConfig": {
"defaultConfig": [
"conversionID",
"eventMappingFromConfig",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no functional impact by removal of pageLoadConversions & dynamicRemarketing ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, these fields are not used anywhere in SDK. it's redundant to keep it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check if any destination is using by querying DB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this flags back as older SDK versions might be using these flags

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are present in destination config, they continue to get sent via sourceConfig API & based on SDK, they get used. But they can't be updated. Right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove it but for that we need migration script.

@mihir-4116 mihir-4116 force-pushed the feat.google_ads_new_ui branch from 4086506 to c97b7b8 Compare November 14, 2023 09:31
@mihir-4116 mihir-4116 requested a review from koladilip November 14, 2023 13:06
@mihir-4116 mihir-4116 requested a review from ItsSudip November 30, 2023 05:55
krishna2020
krishna2020 reviewed Dec 1, 2023
View reviewed changes
src/configurations/destinations/googleads/schema.json
@@ -28,16 +28,38 @@
"Checkout",
"Search",
"AddToCart",
"purchase",
"Purchase",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the case-sensitivity handled in the backend ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, as google ads expect it as Purchase instead of purchase

@mihir-4116 mihir-4116 force-pushed the feat.google_ads_new_ui branch from 4410827 to 7980f27 Compare December 4, 2023 04:24
ItsSudip
ItsSudip previously approved these changes Dec 4, 2023
View reviewed changes
@mihir-4116 mihir-4116 requested a review from ItsSudip December 7, 2023 07:58
ItsSudip
ItsSudip previously approved these changes Dec 7, 2023
View reviewed changes
@mihir-4116 mihir-4116 requested a review from ItsSudip December 20, 2023 05:09
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@devops-github-rudderstack devops-github-rudderstack deleted the feat.google_ads_new_ui branch April 9, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvrach lvrach Awaiting requested review from lvrach lvrach is a code owner

@cisse21 cisse21 Awaiting requested review from cisse21 cisse21 is a code owner

@nidhilashkari17 nidhilashkari17 Awaiting requested review from nidhilashkari17

@debanjan97 debanjan97 Awaiting requested review from debanjan97 debanjan97 is a code owner

@ssbeefeater ssbeefeater Awaiting requested review from ssbeefeater ssbeefeater is a code owner

@AchuthaSourabhC AchuthaSourabhC Awaiting requested review from AchuthaSourabhC

@ruchiramoitra ruchiramoitra Awaiting requested review from ruchiramoitra

@ashishRudder ashishRudder Awaiting requested review from ashishRudder

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs sandeepdsvs is a code owner

@desusai7 desusai7 Awaiting requested review from desusai7

@1abhishekpandey 1abhishekpandey Awaiting requested review from 1abhishekpandey 1abhishekpandey is a code owner

@bardisg bardisg Awaiting requested review from bardisg

@koladilip koladilip Awaiting requested review from koladilip

@krishna2020 krishna2020 Awaiting requested review from krishna2020 krishna2020 is a code owner

@ItsSudip ItsSudip Awaiting requested review from ItsSudip ItsSudip is a code owner

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mihir-4116 @devops-github-rudderstack @krishna2020 @koladilip @ItsSudip