-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Google Tag Manager environment ID and authorization token config values #1894
base: develop
Are you sure you want to change the base?
Conversation
Thank you @tmchow for contributing this PR. |
WalkthroughThis pull request adds two new keys, Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant UI as UI Config Form
participant VAL as Schema Validator
participant CFG as GTM Config Processor
U->>UI: Enter Environment ID & Authorization Token
UI->>VAL: Validate input using regex patterns
VAL-->>UI: Return validation results
UI->>CFG: Send updated configuration
CFG-->>UI: Confirm configuration update
Possibly related PRs
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Corresponds to this change in the rudder-integrations-config repo: rudderlabs/rudder-integrations-config#1894
What are the changes introduced in this PR?
Adds Google Tag Manager settings for Environment ID and Authorization Token which is required for GTM to be used with environments.
https://support.google.com/tagmanager/answer/6311518?hl=en
What is the related Linear task?
n/a
Please explain the objectives of your changes below
Without this, GTM cannot be used to it's full extent with environment which limits it's utility in Rudderstack.
Corresponding change to the GTM script is here:
rudderlabs/rudder-sdk-js#2035
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit