Skip to content

Commit

Permalink
chore: update plugins and integration sdk base url constants and unit…
Browse files Browse the repository at this point in the history
… test (#1654)

* chore: default constant for plugins and integrations base url updated

* chore: updated beta path in unit test
  • Loading branch information
MoumitaM authored Mar 21, 2024
1 parent 14797b5 commit 177421c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@ describe('CDN Paths: getIntegrationsCDNPath', () => {
getSDKUrl.mockImplementation(() => undefined);

const integrationsCDNPath = getIntegrationsCDNPath(dummyVersion, true, undefined);
expect(integrationsCDNPath).toBe(`${SDK_CDN_BASE_URL}/beta/3.0.0-beta/modern/${CDN_INT_DIR}`);
// TODO: change the above to production URLs when beta phase is done
// expect(integrationsCDNPath).toBe(
// `${SDK_CDN_BASE_URL}/latest/${dummyVersion}/modern/${CDN_INT_DIR}`,
// );
expect(integrationsCDNPath).toBe(`${SDK_CDN_BASE_URL}/${dummyVersion}/modern/${CDN_INT_DIR}`);
});
});
7 changes: 2 additions & 5 deletions packages/analytics-js/src/constants/urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@ import { IS_LEGACY_BUILD } from './app';
const BUILD_TYPE = IS_LEGACY_BUILD ? 'legacy' : 'modern';
const SDK_CDN_BASE_URL = 'https://cdn.rudderlabs.com';
const CDN_ARCH_VERSION_DIR = 'v3';
const DEST_SDK_BASE_URL = `${SDK_CDN_BASE_URL}/beta/3.0.0-beta/${BUILD_TYPE}/${CDN_INT_DIR}`;
const PLUGINS_BASE_URL = `${SDK_CDN_BASE_URL}/beta/3.0.0-beta/${BUILD_TYPE}/${CDN_PLUGINS_DIR}`;
// TODO: change the above to production URLs when beta phase is done
// const DEST_SDK_BASE_URL = `${SDK_CDN_BASE_URL}/latest/${CDN_ARCH_VERSION_DIR}/${BUILD_TYPE}/${CDN_INT_DIR}`;
// const PLUGINS_BASE_URL = `${SDK_CDN_BASE_URL}/latest/${CDN_ARCH_VERSION_DIR}/${BUILD_TYPE}/${CDN_PLUGINS_DIR}`;
const DEST_SDK_BASE_URL = `${SDK_CDN_BASE_URL}/${CDN_ARCH_VERSION_DIR}/${BUILD_TYPE}/${CDN_INT_DIR}`;
const PLUGINS_BASE_URL = `${SDK_CDN_BASE_URL}/${CDN_ARCH_VERSION_DIR}/${BUILD_TYPE}/${CDN_PLUGINS_DIR}`;
const DEFAULT_CONFIG_BE_URL = 'https://api.rudderstack.com';

export {
Expand Down

0 comments on commit 177421c

Please sign in to comment.