feat: set server side cookies #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe recent updates to the analytics-js package bring enhancements in URL validation, server-side cookie management, and HTTP client integration. Notable changes include the addition of new utility functions for URL handling, improvements to UserSessionManager for better cookie management, and updates in configuration files to support server-side cookies. Test coverage has also been expanded to accommodate these new functionalities. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…rovider-for-service
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1649 +/- ##
===========================================
+ Coverage 54.60% 54.81% +0.20%
===========================================
Files 463 464 +1
Lines 15701 15797 +96
Branches 3109 3155 +46
===========================================
+ Hits 8574 8659 +85
+ Misses 5854 5825 -29
- Partials 1273 1313 +40 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (9)
- packages/analytics-js-common/src/types/LoadOptions.ts (1 hunks)
- packages/analytics-js/fixtures/msw.handlers.ts (1 hunks)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/public/index.html (1 hunks)
- packages/analytics-js/src/components/core/Analytics.ts (1 hunks)
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (4 hunks)
- packages/analytics-js/src/components/utilities/loadOptions.ts (1 hunks)
- packages/analytics-js/src/services/StoreManager/storages/CookieStorage.ts (2 hunks)
- packages/analytics-js/src/state/slices/loadOptions.ts (1 hunks)
Additional comments: 12
packages/analytics-js/src/state/slices/loadOptions.ts (1)
- 40-40: The addition of the
useServerSideCookieproperty with a default value offalseis correctly implemented. This allows for an opt-in approach to using server-side cookie setting capabilities, aligning with the PR's objectives.packages/analytics-js/__fixtures__/msw.handlers.ts (1)
- 80-87: The addition of the new HTTP POST handler for setting a cookie at
${dummyDataplaneHost}/setCookieis correctly implemented. It simulates server-side cookie setting in a testing environment with appropriate response configuration.packages/analytics-js/src/services/StoreManager/storages/CookieStorage.ts (2)
- 7-7: The addition of the
stateimport from@rudderstack/analytics-js/stateis correctly implemented, facilitating access to the global state within theCookieStorageclass for managing cookie settings.- 43-44: The modifications to the
configuremethod in theCookieStorageclass, including the deletion of theenabledproperty and the assignment ofthis.optionstostate.storage.cookie.value, are correctly implemented. These changes enhance cookie management by aligning with the application's state management strategy.packages/analytics-js-common/src/types/LoadOptions.ts (1)
- 150-151: The addition of the
useServerSideCookieandcookieServerUrlfields to theLoadOptionstype is correctly implemented. These fields enhance cookie management capabilities by enabling server-side cookie setting and specifying a custom base URL for the cookie.packages/analytics-js/src/components/utilities/loadOptions.ts (1)
- 60-61: The modification to the
normalizeLoadOptionsfunction, adding a check to normalize theuseServerSideCookieoption value to a boolean, is correctly implemented. This ensures that the option is correctly interpreted and used within the application.packages/analytics-js/public/index.html (2)
- 82-82: The
pluginsSDKBaseURLdeclaration is commented out in theloadOptionsobject. Could you clarify the reasoning behind this change? It's important to ensure that example configurations in public-facing files are clear and intentional.- 83-83: The
useServerSideCookiedeclaration is added but commented out in theloadOptionsobject. It would be helpful to include a comment explaining the purpose and usage of this option, especially since it's a significant feature introduced by this PR.packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (3)
- 65-79: The addition of the
httpClientproperty and its initialization in the constructor are correctly implemented. This change enables theUserSessionManagerclass to make HTTP requests, which is necessary for the new server-side cookie setting functionality.- 270-288: The
setServerSideCookiemethod is correctly implemented to make an external request for setting cookies from the server side. However, it's important to ensure that the server endpoint (${baseUrl}/setCookie) properly handles the POST request and securely processes the cookie data.- 300-318: The modifications to the
syncValueToStoragemethod to support server-side cookie setting are correctly implemented. WhenuseServerSideCookieis true and the storage type iscookieStorage, the method now correctly callssetServerSideCookiewith the encrypted cookie value. This change aligns with the PR objectives for enhanced cookie management.packages/analytics-js/src/components/core/Analytics.ts (1)
- 245-245: The addition of the
httpClientdependency to theAnalyticsclass constructor is correctly implemented. This change enhances the class's functionality by introducing a new component for handling HTTP requests, which is necessary for the new server-side cookie setting functionality and other HTTP-based interactions.
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
saikumarrs
requested changes
Mar 18, 2024
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/services/StoreManager/storages/CookieStorage.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (11)
- packages/analytics-js-common/src/types/LoadOptions.ts (1 hunks)
- packages/analytics-js/.size-limit.js (1 hunks)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/public/index.html (1 hunks)
- packages/analytics-js/src/components/configManager/ConfigManager.ts (2 hunks)
- packages/analytics-js/src/components/configManager/util/validate.ts (2 hunks)
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (6 hunks)
- packages/analytics-js/src/components/utilities/loadOptions.ts (1 hunks)
- packages/analytics-js/src/constants/logMessages.ts (2 hunks)
- packages/analytics-js/src/services/StoreManager/storages/storageEngine.ts (2 hunks)
- packages/analytics-js/src/state/slices/loadOptions.ts (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- packages/analytics-js-common/src/types/LoadOptions.ts
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts
- packages/analytics-js/public/index.html
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
- packages/analytics-js/src/components/utilities/loadOptions.ts
- packages/analytics-js/src/state/slices/loadOptions.ts
Additional comments: 4
packages/analytics-js/.size-limit.js (1)
- 29-29: The increase in the size limit for the 'Core - CDN' module to '23.5 KiB' seems justified given the new features introduced. However, it's important to continue monitoring the overall size and performance impact of these changes.
packages/analytics-js/src/services/StoreManager/storages/storageEngine.ts (1)
- 46-54: The modifications to
configureCookieStorageEnginealign with the objectives of introducing server-side cookie setting functionality. It's important to ensure that the options passed toCookieStorageare validated and sanitized upstream to prevent potential security issues. Consider adding a comment or documentation to highlight this requirement.packages/analytics-js/src/components/configManager/ConfigManager.ts (1)
- 98-104: The usage of
validateAndReturnCookieServerUrlwithin theinitmethod is appropriate for validating thecookieServerUrl. Ensure that the calling code is prepared to handlenullor errors as a result of the validation, especially if changes are made tovalidateAndReturnCookieServerUrlbased on previous suggestions.packages/analytics-js/src/constants/logMessages.ts (1)
- 94-102: The new error message constants related to server-side cookies functionality are clear and meaningful. Ensure consistent usage of these constants throughout the codebase for effective debugging and error handling.
packages/analytics-js/src/components/configManager/util/validate.ts
Outdated
Show resolved
Hide resolved
…rovider-for-service
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/analytics-js/public/index.html (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/analytics-js/public/index.html
…rovider-for-service
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- packages/analytics-js-common/src/types/LoadOptions.ts (1 hunks)
- packages/analytics-js/public/index.html (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/analytics-js-common/src/types/LoadOptions.ts
- packages/analytics-js/public/index.html
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (6 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
|
Hello! This PR has been open for 20 days without any activity. Therefore, it's considered as stale and is scheduled to be closed in 10 days. If you're still working on this, please remove the 'Stale' label or add a comment to keep it open. Thanks for your contribution! |
…rovider-for-service
…rvice' of https://github.com/rudderlabs/rudder-sdk-js into feature/sdk-1301-create-a-cookie-setter-provider-for-service
packages/analytics-js/src/components/configManager/util/validate.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
|
All the previous comments are addressed |
saikumarrs
requested changes
Apr 29, 2024
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/services/StoreManager/storages/storageEngine.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/configManager/util/validate.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 8
Out of diff range and nitpick comments (1)
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (1)
283-338: Validate the server response status code more robustly insetServerSideCookie.The method checks if
details?.xhr?.status === 200to determine if the request was successful. However, other 2xx status codes could also indicate success. Consider checking for all successful 2xx responses or use a utility function to check for HTTP success status codes.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- packages/analytics-js-common/src/types/ApplicationState.ts (2 hunks)
- packages/analytics-js/.size-limit.js (2 hunks)
- packages/analytics-js/fixtures/msw.handlers.ts (1 hunks)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/src/components/configManager/ConfigManager.ts (4 hunks)
- packages/analytics-js/src/components/configManager/util/validate.ts (2 hunks)
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (5 hunks)
- packages/analytics-js/src/constants/logMessages.ts (2 hunks)
- packages/analytics-js/src/state/index.ts (3 hunks)
- packages/analytics-js/src/state/slices/serverCookies.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/analytics-js/.size-limit.js
Additional Context Used
Learnings (2)
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (1)
User: MoumitaM PR: rudderlabs/rudder-sdk-js#1625 File: packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts:1374-1385 Timestamp: 2024-02-22T10:46:36.393Z Learning: Multiple cookies with the same name are not possible in web browsers; a newer cookie will overwrite an older one if they share the same name.packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts (1)
User: MoumitaM PR: rudderlabs/rudder-sdk-js#1625 File: packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts:1374-1385 Timestamp: 2024-02-22T10:46:36.393Z Learning: Multiple cookies with the same name are not possible in web browsers; a newer cookie will overwrite an older one if they share the same name.
Additional comments not posted (6)
packages/analytics-js/src/state/index.ts (1)
16-16: Integration ofserverSideCookiesStateinto the main application state is correctly implemented.packages/analytics-js/__fixtures__/msw.handlers.ts (1)
80-105: The simulation of the server-side cookie setting feature is correctly implemented. Ensure that the cookie settings such asPath,Domain, andExpiresare correctly configured as per the application requirements.Verification successful
The server-side cookie setting feature in the file
packages/analytics-js/__fixtures__/msw.handlers.tsis correctly implemented. The cookie settings such asPath,Domain, andExpiresare configured as per the application requirements.
- File:
packages/analytics-js/__fixtures__/msw.handlers.tsScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the cookie settings in the simulated server response. # Test: Search for the cookie settings in the handler. Expect: Correct configuration of Path, Domain, and Expires. rg --type js $'Set-Cookie'Length of output: 25
Script:
#!/bin/bash # Description: Verify the cookie settings in the specific file `msw.handlers.ts`. # Test: Search for the cookie settings in the handler within `msw.handlers.ts`. Expect: Correct configuration of Path, Domain, and Expires. rg --type js $'Set-Cookie' -- 'msw.handlers.ts'Length of output: 100
Script:
#!/bin/bash # Description: Locate the file `msw.handlers.ts` in the repository. # Test: Use fd to find the file `msw.handlers.ts` and print its path. fd 'msw.handlers.ts'Length of output: 129
Script:
#!/bin/bash # Description: Verify the cookie settings in the file located at `packages/analytics-js/__fixtures__/msw.handlers.ts`. # Test: Search for the cookie settings in the handler within the specified file. Expect: Correct configuration of Path, Domain, and Expires. rg --type js $'Set-Cookie' -- 'packages/analytics-js/__fixtures__/msw.handlers.ts'Length of output: 101
packages/analytics-js-common/src/types/ApplicationState.ts (1)
156-159: The definition ofServerCookiesStateis correctly implemented, ensuring that the state can handle both the enablement status and the server URL for cookies.packages/analytics-js/src/components/configManager/ConfigManager.ts (1)
97-105: The handling of theuseServerSideCookiesanddataServerUrloptions in theinitmethod is correctly implemented. It ensures that the server-side cookies feature is enabled only if the URL is valid.packages/analytics-js/src/constants/logMessages.ts (1)
94-102: The log messages related to server-side cookie errors are correctly defined, providing clear and actionable error information.packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts (1)
1391-1421: Review the logic for server-side cookie synchronization.The tests for
syncValueToStoragecorrectly handle the scenarios where server-side cookies are enabled and disabled. However, it's crucial to verify that thesetServerSideCookiemethod behaves as expected under various network conditions and server responses. Consider adding tests that simulate network failures and server errors to ensure the system's resilience.
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/configManager/util/validate.ts
Outdated
Show resolved
Hide resolved
saikumarrs
reviewed
May 6, 2024
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Show resolved
Hide resolved
packages/analytics-js/src/services/StoreManager/storages/storageEngine.ts
Outdated
Show resolved
Hide resolved
saikumarrs
requested changes
May 20, 2024
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/configManager/ConfigManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/configManager/ConfigManager.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- packages/analytics-js-common/src/types/ApplicationState.ts (2 hunks)
- packages/analytics-js/tests/components/configManager/validate.test.ts (2 hunks)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/src/components/configManager/ConfigManager.ts (5 hunks)
- packages/analytics-js/src/components/configManager/util/validate.ts (1 hunks)
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (5 hunks)
- packages/analytics-js/src/state/slices/serverCookies.ts (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- packages/analytics-js-common/src/types/ApplicationState.ts
- packages/analytics-js/src/components/configManager/ConfigManager.ts
- packages/analytics-js/src/components/configManager/util/validate.ts
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
- packages/analytics-js/src/state/slices/serverCookies.ts
Additional Context Used
Learnings (1)
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts (2)
User: MoumitaM PR: rudderlabs/rudder-sdk-js#1625 File: packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts:1374-1385 Timestamp: 2024-02-22T10:46:36.393Z Learning: Multiple cookies with the same name are not possible in web browsers; a newer cookie will overwrite an older one if they share the same name.User: saikumarrs PR: rudderlabs/rudder-sdk-js#1708 File: packages/analytics-js-plugins/__tests__/deviceModeTransformation/index.test.ts:10-11 Timestamp: 2024-05-06T08:40:17.868Z Learning: The misuse of `IHttpClient` in type assertions within the file `packages/analytics-js-plugins/__tests__/deviceModeTransformation/index.test.ts` has been corrected by the user.
Additional comments not posted (6)
packages/analytics-js/__tests__/components/configManager/validate.test.ts (2)
Line range hint
5-34: The test cases forvalidateLoadArgsare comprehensive and well-structured.
35-46: The parameterized tests forgetTopDomainUrleffectively cover a variety of URL formats.packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts (4)
23-24: Mocking of external dependencies is correctly implemented.This ensures that the tests do not make actual network requests, which is crucial for reliable and isolated unit tests.
89-89: EnsuredefaultHttpClientis correctly injected intoUserSessionManager.This change is crucial for enabling the manager to make network requests, which is part of the new functionality to handle server-side cookies.
1391-1407: Properly handle the state condition for server-side cookie setting.The conditional logic to check
isEnabledServerSideCookiesbefore invokingsetServerSideCookieis a good practice to ensure that cookies are only set when explicitly enabled.
1425-1571: Ensure robust error handling and fallback mechanisms for server-side cookie setting.The comprehensive tests for different scenarios, including network failures and server unavailability, ensure that the system gracefully handles errors and falls back to client-side cookie management when necessary.
packages/analytics-js/__tests__/components/configManager/validate.test.ts
Outdated
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Show resolved
Hide resolved
packages/analytics-js/__tests__/components/userSessionManager/UserSessionManager.test.ts
Show resolved
Hide resolved
…rovider-for-service
…rovider-for-service
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/public/index.html (1 hunks)
- packages/analytics-js/src/components/configManager/ConfigManager.ts (5 hunks)
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts (5 hunks)
Files skipped from review as they are similar to previous changes (3)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts
- packages/analytics-js/public/index.html
- packages/analytics-js/src/components/userSessionManager/UserSessionManager.ts
Additional comments not posted (2)
packages/analytics-js/src/components/configManager/ConfigManager.ts (2)
34-34: The introduction ofDEFAULT_DATA_SERVICE_ENDPOINTis a good practice for default configurations.
21-21: Ensure consistent use of utility functions across the codebase.
…rvice' of https://github.com/rudderlabs/rudder-sdk-js into feature/sdk-1301-create-a-cookie-setter-provider-for-service
…rovider-for-service
…rovider-for-service
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/analytics-js/tests/components/configManager/validate.test.ts (2 hunks)
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts (3 hunks)
- packages/analytics-js/src/components/configManager/util/validate.ts (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- packages/analytics-js/tests/components/configManager/validate.test.ts
- packages/analytics-js/tests/components/userSessionManager/UserSessionManager.test.ts
- packages/analytics-js/src/components/configManager/util/validate.ts
…rovider-for-service
…rovider-for-service
|
saikumarrs
approved these changes
May 21, 2024
MoumitaM
deleted the
feature/sdk-1301-create-a-cookie-setter-provider-for-service
branch
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-1301/create-a-cookie-setter-provider-for-service
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
New Features
Enhancements
UserSessionManagerwith new properties and methods for improved cookie handling and HTTP requests.Bug Fixes
UserSessionManagerwith an additional custom message parameter.Documentation