-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added custom domain support in ga4 #1697
Conversation
WalkthroughThe Google Analytics 4 ( Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1697 +/- ##
========================================
Coverage 53.92% 53.93%
========================================
Files 461 461
Lines 15615 15616 +1
Branches 3108 3090 -18
========================================
+ Hits 8421 8422 +1
- Misses 5840 5928 +88
+ Partials 1354 1266 -88 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
@manish339k Add browser testcases |
packages/analytics-js-integrations/src/integrations/GA4/browser.js
Outdated
Show resolved
Hide resolved
…rowser.js Co-authored-by: Gauravudia <[email protected]>
done. |
|
PR Description
In this PR, we are adding support in GA4 to take
sdkBaseUrl
from the config and load the gtag.js with{sdkBaseUrl}/gtag/js?id=${measurementId}
. Default value ofsdkBaseUrl
ishttps://www.googletagmanager.com
.Linear task (optional)
Resolves INT-1983
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit