-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoConfig support in FBPixel, add tests #1702
Conversation
WalkthroughThe recent enhancements to the FacebookPixel integration introduce the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1702 +/- ##
===========================================
- Coverage 54.13% 54.12% -0.01%
===========================================
Files 462 462
Lines 15652 15654 +2
Branches 3113 3096 -17
===========================================
Hits 8473 8473
- Misses 5851 5896 +45
+ Partials 1328 1285 -43 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
packages/analytics-js-integrations/src/integrations/FacebookPixel/browser.js
Outdated
Show resolved
Hide resolved
|
PR Description
The Meta Pixel will send button click and page metadata (such as data structured according to Opengraph or Schema.org formats) from your website to improve your ads delivery and measurement and automate your Pixel setup. To configure the Meta Pixel to not send this additional information, we are introducing a UI toggle
Linear task (optional)
https://linear.app/rudderstack/issue/INT-2061/facebook-pixel-is-there-any-way-we-could-add-this-as-a-toggle-in-the
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
New Features
autoConfig
option to better manage analytics configurations.Tests
autoConfig
setting in Facebook Pixel integration.