Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/3.71.0-SDK-2830 into main #1985

Merged
merged 38 commits into from
Jan 6, 2025

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

This PR is created automatically by the GitHub Actions workflow to merge the release branch into the main branch.

Linear Ticket:
https://linear.app/rudderstack/issue/SDK-2830

koladilip and others added 30 commits December 9, 2024 13:13
* refactor: use generated integration constants

* refactor: integration constants

* refactor: integration constants based on pr comments

* refactor: integration constants based on pr comments
fix: update destinations.ts

Co-authored-by: GitHub Actions <[email protected]>
* fix: microsoft clarity load and handle promise for identify

* fix: loading logic

* fix: send set calls to clarity while identify is called before load

* fix: error handling

* chore: address review comments

---------

Co-authored-by: Sai Sankeerth <[email protected]>
* docs: add contribution guide for device mode integration

* chore: add missing npm script

* chore: fix typo

* chore: fix integration development instructions in contributing guide

* fix: add more context for the guide

* style: edit and improve formatting

---------

Co-authored-by: Sai Kumar Battinoju <[email protected]>
* chore: trigger test suites on all deployments

* fix: use gh api

* chore: validate actors in manually invoked workflows
* chore: log gh api response

* chore: fix response assertion

* chore: fix conditions in workflows for actor validations
Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)
  • chore(release)

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 87.95181% with 40 lines in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (93818fe) to head (4c0cce6).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...tegrations/CommonIntegrationsConstant/constants.ts 0.00% 13 Missing ⚠️
...-js-integrations/src/integrations/Sprig/browser.js 82.05% 7 Missing ⚠️
...tions/src/integrations/MicrosoftClarity/browser.js 0.00% 3 Missing and 2 partials ⚠️
...ntegrations/src/integrations/Optimizely/browser.js 0.00% 2 Missing and 1 partial ⚠️
...grations/src/integrations/FacebookPixel/browser.js 0.00% 0 Missing and 2 partials ⚠️
...rations/src/integrations/AdobeAnalytics/browser.js 0.00% 0 Missing and 1 partial ⚠️
...tegrations/src/integrations/AdobeAnalytics/util.js 0.00% 0 Missing and 1 partial ⚠️
...integrations/src/integrations/Amplitude/browser.js 0.00% 0 Missing and 1 partial ⚠️
...grations/src/integrations/DCMFloodlight/browser.js 0.00% 1 Missing ⚠️
...s-js-integrations/src/integrations/Heap/browser.js 0.00% 0 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
+ Coverage   57.68%   61.27%   +3.58%     
==========================================
  Files         485      484       -1     
  Lines       16615    16615              
  Branches     3356     3350       -6     
==========================================
+ Hits         9585    10181     +596     
+ Misses       5758     5167     -591     
+ Partials     1272     1267       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 3, 2025

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Cookies Utils - Legacy - NPM (ESM) 1.54 KB 1.54 KB (0%) 2 KB
Cookies Utils - Legacy - NPM (CJS) 1.75 KB 1.75 KB (0%) 2 KB
Cookies Utils - Legacy - NPM (UMD) 1.54 KB 1.54 KB (0%) 2 KB
Cookies Utils - Modern - NPM (ESM) 1.17 KB 1.17 KB (0%) 1.5 KB
Cookies Utils - Modern - NPM (CJS) 1.4 KB 1.4 KB (0%) 1.5 KB
Cookies Utils - Modern - NPM (UMD) 1.16 KB 1.16 KB (0%) 1.5 KB
Plugins Module Federation Mapping - Legacy - CDN 332 B 332 B (0%) 512 B
Plugins - Legacy - CDN 15.68 KB 15.75 KB (+0.45% ▲) 16 KB
Plugins Module Federation Mapping - Modern - CDN 331 B 331 B (0%) 512 B
Plugins - Modern - CDN 7.2 KB 7.2 KB (0%) 7.5 KB
Common - No bundling 16.22 KB 17.8 KB (+9.75% ▲) 18.4 KB
Load Snippet 762 B 762 B (0%) 1 KB
Core (v1.1) - NPM (ESM) 30.32 KB 30.25 KB (-0.23% ▼) 32 KB
Core (v1.1) - NPM (CJS) 30.53 KB 30.47 KB (-0.2% ▼) 32 KB
Core (v1.1) - NPM (UMD) 30.43 KB 30.29 KB (-0.46% ▼) 32 KB
Core (Content Script - v1.1) - NPM (ESM) 29.92 KB 29.81 KB (-0.37% ▼) 30.5 KB
Core (Content Script - v1.1) - NPM (CJS) 30.09 KB 29.97 KB (-0.41% ▼) 30.5 KB
Core (Content Script - v1.1) - NPM (UMD) 29.88 KB 29.81 KB (-0.24% ▼) 30 KB
Core - Legacy - CDN 48.89 KB 48.99 KB (+0.21% ▲) 49 KB
Core - Modern - CDN 25.01 KB 25.02 KB (+0.05% ▲) 25.5 KB
Service Worker - Legacy - NPM (ESM) 30.59 KB 30.62 KB (+0.1% ▲) 31 KB
Service Worker - Legacy - NPM (CJS) 30.83 KB 30.85 KB (+0.09% ▲) 31 KB
Service Worker - Legacy - NPM (UMD) 30.66 KB 30.58 KB (-0.25% ▼) 31 KB
Service Worker - Modern - NPM (ESM) 25.76 KB 25.71 KB (-0.17% ▼) 26 KB
Service Worker - Modern - NPM (CJS) 26 KB 26 KB (+0.01% ▲) 26.5 KB
Service Worker - Modern - NPM (UMD) 25.75 KB 25.75 KB (+0.01% ▲) 26 KB
Core - Legacy - NPM (ESM) 48.71 KB 48.79 KB (+0.17% ▲) 49 KB
Core - Legacy - NPM (CJS) 48.98 KB 49.05 KB (+0.14% ▲) 49.1 KB
Core - Legacy - NPM (UMD) 48.75 KB 48.84 KB (+0.19% ▲) 49 KB
Core - Modern - NPM (ESM) 24.75 KB 24.75 KB (+0.01% ▲) 25 KB
Core - Modern - NPM (CJS) 24.99 KB 24.94 KB (-0.2% ▼) 25.5 KB
Core - Modern - NPM (UMD) 24.78 KB 24.77 KB (-0.06% ▼) 25 KB
Core (Bundled) - Legacy - NPM (ESM) 48.71 KB 48.79 KB (+0.17% ▲) 49 KB
Core (Bundled) - Legacy - NPM (CJS) 49.01 KB 49.11 KB (+0.21% ▲) 49.2 KB
Core (Bundled) - Legacy - NPM (UMD) 48.75 KB 48.84 KB (+0.19% ▲) 49 KB
Core (Bundled) - Modern - NPM (ESM) 39.78 KB 39.69 KB (-0.21% ▼) 40 KB
Core (Bundled) - Modern - NPM (CJS) 39.96 KB 39.98 KB (+0.06% ▲) 40.5 KB
Core (Bundled) - Modern - NPM (UMD) 39.82 KB 39.78 KB (-0.1% ▼) 40 KB
Core (Content Script) - Legacy - NPM (ESM) 48.17 KB 48.29 KB (+0.27% ▲) 48.5 KB
Core (Content Script) - Legacy - NPM (CJS) 48.43 KB 48.52 KB (+0.2% ▲) 48.6 KB
Core (Content Script) - Legacy - NPM (UMD) 48.2 KB 48.25 KB (+0.1% ▲) 48.5 KB
Core (Content Script) - Modern - NPM (ESM) 39.19 KB 39.22 KB (+0.08% ▲) 39.5 KB
Core (Content Script) - Modern - NPM (CJS) 39.43 KB 39.44 KB (+0.04% ▲) 40 KB
Core (Content Script) - Modern - NPM (UMD) 39.22 KB 39.26 KB (+0.12% ▲) 39.5 KB
All Integrations - Legacy - CDN 95.08 KB 94.7 KB (-0.4% ▼) 95.3 KB
All Integrations - Modern - CDN 90.32 KB 90.37 KB (+0.06% ▲) 91 KB

saikumarrs
saikumarrs previously approved these changes Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikumarrs saikumarrs merged commit 6f50a3c into main Jan 6, 2025
13 of 15 checks passed
@saikumarrs saikumarrs deleted the release/3.71.0-SDK-2830 branch January 6, 2025 06:55
@saikumarrs saikumarrs self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants