feat: delete event handling plugins #2047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis pull request restructures various import paths and method signatures across multiple modules. Notably, the retry queue and schedule modules have been refactored with updated type imports and simplified method signatures. Several files, tests, and type definitions related to the BeaconQueue and XhrQueue functionality have been removed. Changes also include adjustments to configuration, bundle size limits, and browser capability detection (removing Beacon API checks). Overall, the modifications streamline the codebase, remove deprecated plugins and types, and adjust lifecycle and testing assertions. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant RetryQueue
Caller->>RetryQueue: Call requeue(queueItem)
Note right of RetryQueue: Processes queueItem using updated signature (without error parameter)
RetryQueue-->>Caller: Returns updated queue state
sequenceDiagram
participant Analytics
participant PluginsManager
Analytics->>Analytics: Initialize (configured state)
Analytics->>PluginsManager: Load plugins
PluginsManager-->>Analytics: Plugins loaded (status updated to readyExecuted)
Analytics->>Analytics: Invoke lifecycle methods (onPluginsReady, onInitialized, loadDestinations, onDestinationsReady, onReady)
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
saikumarrs
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat.move-event-handling-to-core-sdk-2823-final #2047 +/- ##
===================================================================================
+ Coverage 61.41% 61.43% +0.01%
===================================================================================
Files 478 470 -8
Lines 16404 16193 -211
Branches 3240 3231 -9
===================================================================================
- Hits 10075 9948 -127
+ Misses 5095 5011 -84
Partials 1234 1234 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
saikumarrs
force-pushed
the
feat.delete-event-handling-plugins-sdk-2823
branch
from
c659777 to
e1a7a12
Compare
saikumarrs
commented
Feb 20, 2025
There was a problem hiding this comment.
These tests are temporarily skipped to avoid failing the test cases. Once we build the events delivery functionality in the core SDK, we'll un-skip them again.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I've removed the existing data plane events handling plugins
XhrQueueandBeaconQueueand all their references throughout the code.The
RetryQueuemodule is moved to thecommonpackage as now it'll be utilized in more than one packages (core and plugins).Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2823/move-dataplane-events-dispatch-functionality-to-core-sdk
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
Refactor
Chores
Tests
Bundle Improvements
These improvements lay a solid foundation for future enhancements without altering end-user functionality.