fix: allow handled errors to be processed #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis PR modifies the error handling logic in the analytics-js package. The test case for the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ErrorHandler
participant HTTPClient as DefaultHttpClient
participant Console
Client->>ErrorHandler: Trigger error
ErrorHandler-->>ErrorHandler: Evaluate error type and origin
alt Error qualifies for reporting (including handled exceptions)
ErrorHandler->>HTTPClient: Call getAsyncData() to report error
ErrorHandler->>Console: Log error details
else Error should be ignored
ErrorHandler-->>Client: Discard error
end
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)packages/analytics-js/src/services/ErrorHandler/ErrorHandler.ts (1)⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/unsuppress-npm-errors #2059 +/- ##
=============================================================
Coverage 61.41% 61.42%
=============================================================
Files 478 478
Lines 16404 16405 +1
Branches 3232 3235 +3
=============================================================
+ Hits 10075 10076 +1
+ Misses 5122 5113 -9
- Partials 1207 1216 +9 ☔ View full report in Codecov by Sentry. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
size-limit report 📦
|
koladilip
approved these changes
Feb 24, 2025
1abhishekpandey
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I've allowed handled errors to be processed even if they do not seem to be originated from the SDK. Especially, this is helpful for reporting and logging handled errors from the core SDK in the case of NPM installations.
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-3011/unsuppress-handled-errors-for-npm-installations
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit