fix: handle edge cases in retry queue #2074
Conversation
📝 WalkthroughWalkthroughThis pull request updates the retry queue functionality in the analytics JS plugins. The changes include expanded constructor documentation with additional parameters, refined queue slicing logic, and a simplified Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant RetryQueue
participant Logger
Client->>RetryQueue: Enqueue/Process queue item
RetryQueue->>RetryQueue: Process item (processHead)
alt Processing Successful
RetryQueue-->>Client: Return success result
else Error Occurs
RetryQueue->>Logger: Log detailed error message (with retry attempt info)
alt Max Attempts Not Reached
RetryQueue->>RetryQueue: Requeue item for retry
else Max Attempts Reached
RetryQueue->>Logger: Log message indicating item drop
end
end
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (1)packages/analytics-js-plugins/__tests__/utilities/retryQueue/RetryQueue.test.ts (1)⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (9)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2074 +/- ##
===========================================
+ Coverage 61.51% 61.55% +0.03%
===========================================
Files 478 478
Lines 16437 16447 +10
Branches 3267 3264 -3
===========================================
+ Hits 10112 10124 +12
- Misses 5092 5099 +7
+ Partials 1233 1224 -9 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
size-limit report 📦
|
|
PR Description
I've fixed the following issues in the retry queue module:
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-3066/event-processing-queue-issues
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Refactor