Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configurable transformer http client in processor, router #5455

Draft
wants to merge 9 commits into
base: chore.configurableCSLB
Choose a base branch
from

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Jan 24, 2025

Description

Configurable http Client(Doer) in processor, rt transformers. Doesn't include oauth clients in rt transform at this point.

Linear Ticket

On top of #5451

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 58.26772% with 53 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (2bcb2c6) to head (04fe9de).

Files with missing lines Patch % Lines
internal/transformer-client/client.go 36.14% 51 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           chore.configurableCSLB    #5455      +/-   ##
==========================================================
+ Coverage                   74.73%   74.77%   +0.04%     
==========================================================
  Files                         440      441       +1     
  Lines                       61699    61760      +61     
==========================================================
+ Hits                        46108    46180      +72     
+ Misses                      13045    13034      -11     
  Partials                     2546     2546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth marked this pull request as draft January 24, 2025 11:15
@Sidddddarth Sidddddarth changed the title chore: make cslb configurable chore: configurable transformer http client in processor, router Jan 24, 2025
@Sidddddarth Sidddddarth force-pushed the chore.configurableCSLBInProcRouter branch 3 times, most recently from 5f58ffb to 031edfc Compare January 29, 2025 09:02
@Sidddddarth Sidddddarth force-pushed the chore.configurableCSLBInProcRouter branch from 031edfc to 04fe9de Compare January 29, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant