-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement snowpipe destination config validation #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhar-rudder
commented
Feb 4, 2025
router/batchrouter/asyncdestinationmanager/snowpipestreaming/snowpipestreaming.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5472 +/- ##
=======================================
Coverage 74.89% 74.90%
=======================================
Files 458 458
Lines 63268 63266 -2
=======================================
+ Hits 47385 47388 +3
+ Misses 13229 13226 -3
+ Partials 2654 2652 -2 ☔ View full report in Codecov by Sentry. |
achettyiitr
reviewed
Feb 5, 2025
router/batchrouter/asyncdestinationmanager/snowpipestreaming/snowpipestreaming.go
Outdated
Show resolved
Hide resolved
router/batchrouter/asyncdestinationmanager/snowpipestreaming/snowpipestreaming.go
Outdated
Show resolved
Hide resolved
achettyiitr
approved these changes
Feb 5, 2025
c6aa96c
to
eff699d
Compare
eff699d
to
672a444
Compare
vyeshwanth
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Implementation
StepsToValidate
method to return relevant steps for Snowpipe destinationDestinationValidationResponse
struct frominternal/model
package tovalidations
package so that it can be accessed insnowpipestreaming
packagevalidator
field in snowpipe'sManager
struct which is responsible for validating the destination configUpload
function to call the validator whenever there is an authorization error. And if the response is not successful, the error is being returned.Security