fix: snowpipe backoff missing for validation error #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhar-rudder
commented
Feb 12, 2025
| @@ -138,6 +138,8 @@ func (m *Manager) createChannel( | |||
| } | |||
| m.channelCache.Store(tableName, resp) | |||
| return resp, nil | |||
| case internalapi.ErrValidationError: | |||
| return nil, fmt.Errorf("%w, %w", errAuthz, err) | |||
There was a problem hiding this comment.
Technically speaking, this is an authentication error and not authorization. But I don't think there is a need for that distinction yet.
shekhar-rudder
force-pushed
the
war-240-snowpipe-config-validation
branch
from
46d907c to
3b9edee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a Snowpipe destination is created with an invalid private key, the Snowpipe client returns an
ERR_VALIDATION_ERRORcode. Previously, this was handled in the default case, preventing it from being classified as anAuthzerror. As a result, neither backoff nor config validation occurred in the Upload function.This PR fixes the issue by correctly identifying and returning this error as
Authz.ErrAuthenticationFailedfor invalid user name andErrRoleDoesNotExistOrNotAuthorizedfor invalid roleSecurity