Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade json-template-engine #149

Merged
merged 13 commits into from
Jun 7, 2024
Merged

chore: upgrade json-template-engine #149

merged 13 commits into from
Jun 7, 2024

Conversation

koladilip
Copy link
Collaborator

@koladilip koladilip commented Jun 7, 2024

What are the changes introduced in this PR?

Upgrade Json template engine 0.10.3

What is the related Linear task?

Resolves INT-2160

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

  • Chores
    • Updated Node.js version to 18.20.3 for improved compatibility and performance.
    • Updated several dependencies to their latest versions for enhanced security and functionality.

Copy link

coderabbitai bot commented Jun 7, 2024

Warning

Rate limit exceeded

@koladilip has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 39 minutes and 21 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 872f6b9 and 3ca4bd2.

Walkthrough

The recent updates involve modifying the .nvmrc file to specify a new Node.js version, 18.20.3, and updating several dependencies in the package.json file. These changes ensure compatibility with the latest Node.js version and incorporate the latest improvements and fixes in the dependencies.

Changes

File Change Summary
.nvmrc Updated Node.js version from 18.19.0 to 18.20.3.
package.json Incremented versions of dependencies: @aws-crypto/sha256-js, @rudderstack/json-template-engine, jsonata, object-sizeof, and yaml.

Poem

In the code's vast, intricate land,
Node.js now lends a newer hand,
Dependencies refreshed, so neat,
Making our app ever more fleet.
With versions new, we boldly stand,
Progress and bugs, now well in hand.
🐇✨🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 41ce2d6 and 872f6b9.

Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (2)
  • .nvmrc (1 hunks)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (2)
  • .nvmrc
  • package.json

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.87% (-0.04% 🔻)
2230/2233
🟢 Branches
99.57% (-0.22% 🔻)
458/460
🟢 Functions 100% 161/161
🟢 Lines
99.87% (-0.04% 🔻)
2230/2233
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / factory.ts
98.11% (-1.89% 🔻)
90.91% (-9.09% 🔻)
100%
98.11% (-1.89% 🔻)

Test suite run success

211 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 3ca4bd2

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (a15fc62) to head (3ca4bd2).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #149      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%     
===========================================
  Files           55       61       +6     
  Lines         2001     2233     +232     
  Branches       363      407      +44     
===========================================
+ Hits          2001     2230     +229     
- Misses           0        2       +2     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jun 7, 2024

@koladilip koladilip requested review from sanpj2292 and ItsSudip June 7, 2024 05:48
@koladilip koladilip merged commit d3189e8 into main Jun 7, 2024
11 checks passed
@koladilip koladilip deleted the chore.upgrade-packages branch June 7, 2024 05:50
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
@coderabbitai coderabbitai bot mentioned this pull request Jan 20, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants