feat: allow overriding rudder-config.yaml settings from values.yaml #59
Conversation
README.md
Outdated
| @@ -93,7 +94,8 @@ $ helm install --name my-release \ | |||
| ``` | |||
|
|
|||
| **Note:** Configuration specific to: | |||
| - Backend can be edited in [rudder-config.yaml](https://docs.rudderlabs.com/administrators-guide/config-parameters). | |||
|
|
|||
| - Backend can be edited in [rudder-config.yaml](https://docs.rudderlabs.com/administrators-guide/config-parameters). or in values.yaml under `backend.config.overrides`. | |||
There was a problem hiding this comment.
The mentioned doc link is broken
There was a problem hiding this comment.
Created a separate issue to fix this after this merge
There was a problem hiding this comment.
We have deprecated this guide as it had outdated information. Should we just point to the rudder-config.yaml file? @gitcommitshow @gane5hvarma
There was a problem hiding this comment.
I can do that @ameypv-rudder
bdashrad
requested review from
gitcommitshow and
ameypv-rudder
and removed request for
gitcommitshow
| @@ -69,6 +69,12 @@ backend: | |||
|
|
|||
| config: | |||
| mountPath: "/etc/rudderstack" | |||
| # -- rudder-server config overrides | |||
| # See [config parameters](https://docs.rudderlabs.com/administrators-guide/config-parameters) for more details | |||
There was a problem hiding this comment.
The doc link provided doesn't exist..
There was a problem hiding this comment.
Yep - as mentioned above:
We have deprecated this guide as it had outdated information. Should we just point to the rudder-config.yaml file?
| @@ -1,3 +1,5 @@ | |||
| {{- $baseConfig := .Files.Get "rudder-config.yaml" | fromYaml -}} | |||
| {{- $rudderConfig := mustMergeOverwrite $baseConfig .Values.backend.config.overrides -}} | |||
There was a problem hiding this comment.
this code is duplicated... Can we write a helm function returning the template and use it for checksum and config yaml instead??
There was a problem hiding this comment.
sorry, i missed that, i can always put in another PR
Description of the change
Type of change
Related issues
Checklists
Development
Code review