avm2: Improve drawing paths in Graphics #16765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
graphics-draw-path
branch
from
264aa7d
to
d8a860a
Compare
Dinnerbone
approved these changes
Jun 19, 2024
This patch improves drawing paths in Graphics: * no error is thrown when there are 0 commands, * no error is thrown when there are missing data points, * an error is thrown when the number of coordinates is odd, * no error is thrown and command processing is stopped when an unknown command is encountered, * the vector with parsed commands is removed, as it's not needed.
This test verifies the behavior of drawing paths using Graphics.
Dinnerbone
force-pushed
the
graphics-draw-path
branch
from
d8a860a
to
c2029c5
Compare
adrian17
approved these changes
Jun 19, 2024
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14674.
This patch improves drawing paths in Graphics:
After this PR the winding behavior is still missing, but it's covered by the newly added test. (The output will have to be updated when it's implemented.)
This PR shares one commit with #16762, it does not matter which PR it's merged with.