web: Core UI improvements #16793
Merged
web: Core UI improvements #16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WumboSpasm
force-pushed
the
web-ui-improvements
branch
from
11d5d7c
to
d957853
Compare
WumboSpasm
force-pushed
the
web-ui-improvements
branch
from
85b3faf
to
fe84a2e
Compare
|
Should we also add rounded corners to the context menu? |
|
Personally I like square context menu, the window rounding is quite strong. Maybe a subtle one would look okay, but we can discuss that for a followup PR? |
Dinnerbone
approved these changes
Jun 30, 2024
Same. The radius that Windows 11 has on either, is too much for my taste. Not to mention Android, even the screens! 😵 The ones in KDE feel just right to me: But I don't mind actual corners either, for sure. |
torokati44
force-pushed
the
web-ui-improvements
branch
2 times, most recently
from
f382974
to
67566ac
Compare
Dark mode support has been added to the context menu as well as the the Volume and Save Manager modals. The latter two have also received significant visual upgrades.
- Open modals now dim the player and prevent interaction with the underlying content until it is closed - Right-clicking outside of an open modal now closes it instead of displaying the browser context menu - Fixed a regression where right-clicking with the Ruffle context menu open would open the browser context menu
This resolves (literal) edge cases where opening the context menu too close to the right-hand side of the player would inadvertently wrap the lengthiest menu item.
This lets the context menu escape the bounds of the player and keeps modals in the center of the player at small widths.
There was a general consensus in the Ruffle Discord that this functionality was awkward and unneeded (on top of already not working as intended).
Dinnerbone
force-pushed
the
web-ui-improvements
branch
from
67566ac
to
844bf02
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes of note:
Tasks:
I plan on making a separate PR for player overlay improvements.