-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Add ruffle()
(Version 1) API
#17939
base: master
Are you sure you want to change the base?
Conversation
web/packages/core/src/public/v1.ts
Outdated
* | ||
* @param observer The observer that will be called for each trace. | ||
*/ | ||
set traceObserver(observer: ((message: string) => void) | null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to set the trace observer, as today - or set a trace observer?
I've gone ahead and changed |
6ff7d0d
to
875e781
Compare
Renamed |
At this commit, the V1 API is identical to Legacy API
Changed |
Made |
Bikeshedding time, here's the chance to decide what the "v1 api" looks like before we lock it in.
The only change so far is that I've added a specific method for calling EI, vs the very easy-to-break and implicit "the method will exist, trust me". I'm awaiting feedback before touching anything else.
Whilst this is "version 1" (
PlayerV1
interface), if we never add a V2 that's totally fine.ruffle()
is the same asruffle(1)
.Things to consider for each existing member of the API: