Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: PluginArray, MimeType and MimeTypeArray prototype spoofing #18229

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

evilpie
Copy link
Collaborator

@evilpie evilpie commented Oct 10, 2024

This is enough to fool https://fingerprintjs.github.io/BotD/main/, but doesn't require a huge refactoring.

The only annoying part is faking MimeType, which is not a constructable type in the DOM, so we have to create a new wrapper for it.

This is a replacement for #18157.

@evilpie evilpie force-pushed the plugins-array branch 3 times, most recently from 73bb179 to b92b459 Compare October 10, 2024 09:41
@evilpie evilpie changed the title web: PluginsArray and MimeTypeArray prototype spoofing web: PluginArray, MimeType and MimeTypeArray prototype spoofing Oct 10, 2024
@evilpie evilpie marked this pull request as ready for review October 10, 2024 09:41
@evilpie evilpie added A-web Area: Web & Extensions T-fix Type: Bug fix (in something that's supposed to work already) labels Oct 10, 2024
@Dinnerbone
Copy link
Contributor

Do you think we can add a test with that script on it, like how we check that we fool swfobject?

@evilpie evilpie added the waiting-on-review Waiting on review from a Ruffle team member label Oct 13, 2024
@evilpie evilpie force-pushed the plugins-array branch 2 times, most recently from 0038ba4 to 60c78a0 Compare October 13, 2024 10:00
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (and thanks @lihe07!)

@evilpie evilpie merged commit 549673d into ruffle-rs:master Oct 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web Area: Web & Extensions T-fix Type: Bug fix (in something that's supposed to work already) waiting-on-review Waiting on review from a Ruffle team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants