Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_ui: Improve layout debug boxes #18258

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Oct 13, 2024

Displaying all at once would be a mess, so this patch adds a way of enabling and disabling specific types of layout debug boxes.

Hopefully we'll be able to reduce the number of different kinds of bounds soon, but unless it's done, displaying any of them is very useful for debugging.

image

@kjarosh kjarosh added A-desktop Area: Desktop Application T-feature Type: New Feature (that Flash doesn't have) labels Oct 13, 2024
@kjarosh kjarosh added the waiting-on-review Waiting on review from a Ruffle team member label Oct 13, 2024
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love debug improvements :D Thank you!

Displaying all at once would be a mess, so this patch adds
a way of enabling and disabling specific types of layout
debug boxes.
@Dinnerbone Dinnerbone enabled auto-merge (rebase) October 15, 2024 19:15
@Dinnerbone Dinnerbone merged commit 1dc9085 into ruffle-rs:master Oct 15, 2024
17 checks passed
@danielhjacobs danielhjacobs removed the waiting-on-review Waiting on review from a Ruffle team member label Oct 15, 2024
@kjarosh kjarosh deleted the text-layout-boxes-debug branch October 16, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application T-feature Type: New Feature (that Flash doesn't have)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants