avm2: Fix mouse pick on non-interactive objects with masks #18311
+67
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
kjarosh
force-pushed
the
avm2-mpick-non-inter-mask
branch
from
6620769
to
6179c49
Compare
Dinnerbone
reviewed
Oct 18, 2024
kjarosh
force-pushed
the
avm2-mpick-non-inter-mask
branch
2 times, most recently
from
bbcde7a
to
4447361
Compare
Dinnerbone
approved these changes
Oct 18, 2024
Mouse pick should take into account that a non-interactive object may have a mask, in which case the hit test should also be performed on the mask.
This test verifies mouse picking behavior on non-interactive objects with masks.
kjarosh
force-pushed
the
avm2-mpick-non-inter-mask
branch
from
4447361
to
cec62f1
Compare
|
Just fixed the commit message so that it doesn't suggest we should hit test the mask only 👀 |
Lord-McSweeney
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18038.
Mouse pick should take into account that a non-interactive object may have a mask, in which case the hit test should also be performed on the mask.