refactor: Add InputEvent #19544
Merged
refactor: Add InputEvent #19544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
reviewed
Feb 17, 2025
kjarosh
force-pushed
the
input-event
branch
2 times, most recently
from
9396767 to
bcc8281
Compare
evilpie
reviewed
Feb 18, 2025
evilpie
reviewed
Feb 18, 2025
evilpie
approved these changes
Feb 18, 2025
This refactor makes code simpler by merging map_input_event and handle_event in input into process_input_event. This makes it unnecessary to invoke map_input_event from input and then pass the mapped input again to handle_event.
This refactor adds InputEvent, which is a processed PlayerEvent: 1. it does not contain gamepad events, as they are already mapped, 2. it always contains click index, as it's inferred when processing input.
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor simplifies code and is a first step towards tidying up and unifying input handling across platforms.
The most important improvement is the addition of
InputEvent, which represents a mappedPlayerEventrelated to input. It proves to be useful even now by discarding gamepad events and having click index present at all times. In the future this will make it possible to pass information about keys inPlayerEventwithout any knowledge about Flash Player (so noKeyCode).