desktop: Implement crash report dialog when a panic happens

[Dinnerbone]

When a panic happens:

Pressing Yes takes you to this new issue template, prefilled

[Bale001]

We should also include the AVM2 stack trace in the crash report, which will be helpful for AS3 bugs

[Dinnerbone]

@Bale001 how safe is our callback collection? Is there any possibility of it panicking during access?

[Bale001]

@Bale001 how safe is our callback collection? Is there any possibility of it panicking during access?

It's safe to access - StaticCallstack::avm2 will simply do nothing if it can't access the callstack

[Dinnerbone]

New example form

[firoball]

Small thing: Is it really wanted that "additional information" is already pre-filled with an example in the form? People might overlook (or not even care) and just submit whatever is already listed there (Radeon adapter etc.). When reviewing the issue later on, this could cause confusions.

[Dinnerbone]

They can't just hit submit as some fields are required but empty. If we don't prefill system info, I'm not sure we'd ever get that info to honest

[Bale001]

@Dinnerbone My only concern is that StaticCallstack::avm2 currently still calls the closure even with an empty stack trace, so we should make sure the stack trace isn't empty before including it (Or modify StaticCallstack::avm2 to not call the closure with an empty stack trace)

[Dinnerbone]

Small thing: Is it really wanted that "additional information" is already pre-filled with an example in the form? People might overlook (or not even care) and just submit whatever is already listed there (Radeon adapter etc.). When reviewing the issue later on, this could cause confusions.

I just re-read this and maybe there's some confusion - the info prefilled is the users info, not example info. The link I gave as an example for this PR is what I got when I hit the "yes" button, but other users will get their own info.

[firoball]

Small thing: Is it really wanted that "additional information" is already pre-filled with an example in the form? People might overlook (or not even care) and just submit whatever is already listed there (Radeon adapter etc.). When reviewing the issue later on, this could cause confusions.

I just re-read this and maybe there's some confusion - the info prefilled is the users info, not example info. The link I gave as an example for this PR is what I got when I hit the "yes" button, but other users will get their own info.

Ah, got it. So I am seeing your system details only since it is preview for this PR.
No issue then. Sorry for the confusion.

[Dinnerbone]

New example form

Turns into this: Dinnerbone#22