fix failure tests

ruflin · Aug 5, 2020 · dece761 · dece761
1 parent 5693764
commit dece761
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/ClientConfiguration.php b/src/ClientConfiguration.php
@@ -83,6 +83,11 @@ public static function fromDsn(string $dsn): self
             $clientConfiguration->set('password', \urldecode($parsedDsn['pass']));
         }
 
+        if (isset($parsedDsn['pass']) && isset($parsedDsn['user'])) {
+            $clientConfiguration->set('auth_type', 'basic');
+        }
+
+
         if (isset($parsedDsn['port'])) {
             $clientConfiguration->set('port', $parsedDsn['port']);
         }

diff --git a/tests/ClientConfigurationTest.php b/tests/ClientConfigurationTest.php
@@ -39,6 +39,7 @@ public function testFromSimpleDsn(): void
             'bigintConversion' => false,
             'username' => null,
             'password' => null,
+            'auth_type' => null,
         ];
 
         $this->assertEquals($expected, $configuration->getAll());
@@ -62,6 +63,7 @@ public function testFromDsnWithParameters(): void
             'bigintConversion' => true,
             'username' => 'user',
             'password' => 'p4ss',
+            'auth_type' => 'basic',
             'extra' => 'abc',
         ];
 
@@ -87,6 +89,7 @@ public function testFromEmptyArray(): void
             'bigintConversion' => false,
             'username' => null,
             'password' => null,
+            'auth_type' => null
         ];
 
         $this->assertEquals($expected, $configuration->getAll());
@@ -114,6 +117,7 @@ public function testFromArray(): void
             'bigintConversion' => false,
             'username' => 'Jdoe',
             'password' => null,
+            'auth_type' => null,
             'extra' => 'abc',
         ];
 
@@ -147,6 +151,7 @@ public function testGet(): void
             'bigintConversion' => false,
             'username' => null,
             'password' => null,
+            'auth_type' => null,
         ];
 
         $this->assertEquals($expected, $configuration->get(''));

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -40,6 +40,7 @@ public function testConstructWithDsn(): void
             'bigintConversion' => false,
             'username' => 'user',
             'password' => 'p4ss',
+            'auth_type' => 'basic',
             'connectionStrategy' => 'Simple',
         ];