Add coverage to CI

[franmomu]

I guess once merged it will have something to compare 🤔

[ruflin]

+1 on adding this. The concern I have is on what diff it will show for each PR? Will it just compare the lines changed or will now each PR have a very lengthy list like this PR does? We do not have 100% coverage and I don't think it is the goal, it is more about good coverage (whatever that means).

[franmomu]

+1 on adding this. The concern I have is on what diff it will show for each PR? Will it just compare the lines changed or will now each PR have a very lengthy list like this PR does? We do not have 100% coverage and I don't think it is the goal, it is more about good coverage (whatever that means).

It will only compare the lines changed like in doctrine/orm#9377 for example. Yeah it will also show if a change modifies the coverage significantly.

[ruflin]

That is what I'm hoping for. The odd part in this PR is that I see all these:

I'm now wondering if this is a beta feature I have enabled or everyone is seeing this under "Files changed"?

[franmomu]

Yeah I see that too, I guess is what codecov is returning in https://github.com/ruflin/Elastica/pull/2072/checks?check_run_id=6726796537

In theory, next PRs won't show those annotations.

[ruflin]

Lets try it out, we can always disable it if needed. We had coverage reporting in the past, not sure when I got lost. There is even still the badge in the README.md file linked to https://codecov.io/github/ruflin/Elastica?branch=master