Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in design.md #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typos in design.md #199

wants to merge 1 commit into from

Conversation

sattlerc
Copy link

Signed-off-by: Christian Sattler [email protected]

@vtorri
Copy link

vtorri commented Feb 21, 2022

this PR seems good

@rui314 rui314 force-pushed the main branch 10 times, most recently from 5ca2bb9 to 708ad63 Compare April 29, 2022 11:29
@rilysh
Copy link
Contributor

rilysh commented Jan 13, 2023

There's another typo, seems like this PR hasn't been covered yet.
https://github.com/rui314/mold/blob/main/docs/design.md#linker-script
We have to implement a subset of the linker script language anwyay - Change anwyay to anyway

@rui314
Copy link
Owner

rui314 commented Jan 14, 2023

I don't really care too much about typos in the comments and these supplemental documents that are intended to be read only by developers.

@gruenich
Copy link
Contributor

gruenich commented Oct 21, 2023

@rui314 Is there a reason not merge this? When people find typos, they are willing try to help the project. Just merging them would be the easiest for you, wouldn't it?

Copy link

@david-alvarez-rosa david-alvarez-rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants