Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Use std::call_once to arrange timer record stop #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmantipov
Copy link
Contributor

Prefer std::once_flag and std::call_once() over plain
C-style flag to arrange (the body of) TimerRecord::stop()
to execute just once, adjust related code.

Signed-off-by: Dmitry Antipov [email protected]

Prefer 'std::once_flag' and 'std::call_once' over plain
C-style flag to arrange (the body of) 'TimerRecord::stop()'
to execute just once, adjust related code.

Signed-off-by: Dmitry Antipov <[email protected]>
@rui314
Copy link
Owner

rui314 commented Feb 14, 2022

std::call_once is used to make the thing that is protected by call_once thread-safe. In this case, stop is called by a single thread, so we don't need to use call_once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants