events(fix): add mentions in the plain edit event when replacing an event with no initial mentions #1991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a replacement event, there are two places where we set mentions, if provided:
m.new_content
field.Mentions are fully included in the
m.new_content
variant, but for the event content itself, mentions that were already present were filtered out. Unfortunately, this code was no correct when the original event had no mentions at all: in this case, the mentions present in the event content itself would be empty, because of a lack of a special case in the code handling those mentions.The new test introduced acts as a regression test; it fails on
main
at line 869, because mentions are set toNone
there.Found while working on matrix-org/matrix-rust-sdk#4464.