Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codeberg support #525

Closed
wants to merge 26 commits into from
Closed

Codeberg support #525

wants to merge 26 commits into from

Conversation

Jvr2022
Copy link
Contributor

@Jvr2022 Jvr2022 commented Mar 11, 2024

tested

rumboalla
rumboalla requested changes Mar 11, 2024
View reviewed changes
Copy link
Owner

@rumboalla rumboalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, almost there 👍

app/src/main/kotlin/com/apkupdater/data/codeberg/CodeBergApp.kt Outdated Show resolved Hide resolved
app/src/main/kotlin/com/apkupdater/repository/CodeBergRepository.kt Outdated Show resolved Hide resolved
@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Mar 12, 2024

Ready for review @rumboalla

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Mar 12, 2024

#394

@rumboalla
Copy link
Owner

This last commit broke the build

@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Mar 18, 2024 •
edited
Loading

I am looking how I can fix it

@rumboalla
Copy link
Owner

Please reopen if you get this working.
As it is:

  1. Has conflicts
  2. Doesn't build.
  3. Even if it built, it would not work. Looks like the CodeBerg API is not implemented properly.
  4. Missing basic things. The new repo for example is not added to the Updates/Search viewmodels.

@rumboalla rumboalla closed this Mar 24, 2024
@rumboalla rumboalla mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumboalla rumboalla rumboalla requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jvr2022 @rumboalla