Feature/integration tests config #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @vpodorozh, thank you for the PR. @mwr and I reviewed this PR, and we have the following change requests:
|
| - name: mariadb:10.4 | ||
| alias: db | ||
| command: ["--innodb-buffer-pool-size=1024M --innodb-log-buffer-size=32M --max_allowed_packet=325058560"] | ||
| - name: docker.elastic.co/elasticsearch/elasticsearch:7.6.2 |
There was a problem hiding this comment.
Research if this can be dynamic
| ELASTICSEARCH_PORT: 9200 | ||
|
|
||
| # mysql config for integration tests | ||
| INSTALL_CONFIG_MYSQL: > |
There was a problem hiding this comment.
Remove this and point the Var to the default Magento path. We have to check in the config.php into VCS then.
There was a problem hiding this comment.
To set the ENVIRONMENT Variables, you can work with sed
There was a problem hiding this comment.
Replace only on lines matching the line pattern:
sed '/line_pattern/s/find/replace/' filename
| - ${PHP_BIN} bin/magento | ||
| - echo "---------- MAGENTO SETUP:INSTALL ----------" | ||
| ## install magento, using 'yes' to answer all interaction questions (yes |) and ignoring all warnings that could occur while installation ( || true) | ||
| - yes | ${PHP_BIN} bin/magento setup:install --db-host=${APP_DB_HOST} --db-name=${APP_DB_NAME} --db-password=${APP_DB_PASS} --db-user=${APP_DB_USER} --search-engine="elasticsearch7" --elasticsearch-host=${ELASTICSEARCH_HOST} --elasticsearch-port=${ELASTICSEARCH_PORT} [email protected] --admin-firstname=Admin --admin-lastname=Admin --admin-password=admin123 --admin-user=admin --backend-frontname=admin --base-url=http://build.run-as-root.test --currency=EUR --language=en_US --session-save=files --timezone=Europe/Berlin --use-rewrites=1 -vvv || true |
There was a problem hiding this comment.
Please also use redis caching here.
There was a problem hiding this comment.
Please rename the admin-email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing integration tests configs: