add organization id and project id as args #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disiok
approved these changes
Feb 11, 2025
Disiok
reviewed
Feb 11, 2025
Comment on lines
-39
to
-40
| poetry_version: ${{ env.POETRY_VERSION }} | ||
| python_version: ${{ env.PYTHON_VERSION }} |
There was a problem hiding this comment.
causing publish error apparently
Disiok
reviewed
Feb 11, 2025
| @@ -639,7 +662,7 @@ async def _create_job( | |||
| if self.page_suffix is not None: | |||
| data["page_suffix"] = self.page_suffix | |||
|
|
|||
| if self.parsing_instruction is not None: | |||
| if self.parsing_instruction: | |||
There was a problem hiding this comment.
what's the default? empty str?
There was a problem hiding this comment.
yes, and was causing this to print even though its technically unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional args that get added as query params for org and project id
Also fixed the deprecation print for parsing instruction