Support MariaDB 11.7 in the MariaDB vector store integration #17497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
| To learn more about the feature, check the [Vector Overview](https://mariadb.com/kb/en/vector-overview/) in the MariaDB docs. | ||
| To learn more about the feature in MariaDB, check its [Vector Overview documentation](https://mariadb.com/kb/en/vector-overview/). | ||
|
|
||
| Please note that versions before `0.0.3` of this package are not compatible with MariaDB 11.7 and later. |
logan-markewich
approved these changes
Jan 13, 2025
…ration The complex query we used before is not needed now because the bug MDEV-34774 is fixed in MariaDB 11.7.
karsov
force-pushed
the
mariadb-vector-store-db-update
branch
from
dc70a20 to
db6ac68
Compare
dosubot
bot
added
size:L
|
Rebased from |
logan-markewich
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the MariaDB vector store integration to work with MariaDB 11.7.
Currently, it is working only for the one-off MariaDB 11.6 Vector Preview release which is not supported further. 11.7 is the next LTS (long-term support) release of MariaDB so with the changes here we should be able to use MariaDB and LlamaIndex for production workloads and not only for investigation purposes.
There are significant differences between the SQL syntax in MariaDB between the vector preview release and 11.7 which means that older version of the integration cannot work with MariaDB 11.7, and the code here doesn't work with the MariaDB 11.6 Vector Preview release. It doesn't make sense to spent time on support since MariaDB 11.6 Vector Preview was a one-off release and is not supported.
Version Bump
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods