Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed a dead link from fine-tuning.md in docs #17652

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Riddhimaan-Senapati
Copy link
Contributor

Description

Removed a dead link in the fine-tuning.md in docs as the file is no longer present in the repository. This is the link that was removed: https://docs.llamaindex.ai/en/stable/optimizing/examples/finetuning/gradient/gradient_fine_tuning.ipynb

Fixes #17619

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 28, 2025
@Riddhimaan-Senapati
Copy link
Contributor Author

@tobi @wpiekutowski @xevo @bborn @logan-markewich Can anyone of you review my PR?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2025
@logan-markewich logan-markewich merged commit 4d395a7 into run-llama:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
2 participants