Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB Vector Store Integration: Add tuning parameters and utility functions #17791

Merged
merged 24 commits into from
Feb 13, 2025

Conversation

vjr
Copy link
Contributor

@vjr vjr commented Feb 11, 2025

Description

Add default_m and ef_search MariaDB Vector system parameters to allow users to adjust for performance improvements. See https://mariadb.com/kb/en/vector-system-variables/

Also add two utility functions viz. count() and drop() to the implementation.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 11, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) February 13, 2025 04:18
@vjr vjr requested a review from logan-markewich February 13, 2025 08:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 13, 2025
@logan-markewich logan-markewich merged commit e5f1435 into run-llama:main Feb 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants