fix: Minor bug in determining teams for gitlab #5294
Merged
+97
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
Signed-off-by: Luke Massa <[email protected]>
lukemassa
force-pushed
the
fix_minor_bug_in_get_teams_in_gitlab
branch
from
994c26a to
c5fcce0
Compare
jamengual
approved these changes
Feb 3, 2025
bub3n
pushed a commit
to bub3n/atlantis
that referenced
this pull request
Feb 3, 2025
Signed-off-by: Luke Massa <[email protected]> Signed-off-by: Petr Bubenik <[email protected]>
1 task
bub3n
pushed a commit
to bub3n/atlantis
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Luke Massa <[email protected]> Signed-off-by: Petr Bubenik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix minor bug in determining teams for gitlab where if zero or more than one user is found, we return
nilinstead of an error.why
I discovered this while working on #5269.
This is unlikely to ever come up, but the logic here has a subtle bug. When errors.Wrap(err, "...") is passed a
nilerror, it returnsnil. This means if either of these error conditions occurred, we would incorrectly be returningnilfor error instead of the error.tests
I added some unit tests to cover these cases, and confirmed they failed on main.
references