Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: Expand http module with put, delete, head, auth and more #819

Merged
merged 2 commits into from
Oct 29, 2024
Merged

modules: Expand http module with put, delete, head, auth and more #819

merged 2 commits into from
Oct 29, 2024

Conversation

ramon-bernardo
Copy link
Contributor

This PR significantly enhances the HTTP module by introducing...

METHODS

  • Put, Delete, Head, Form, Auth's, Timeout.

This PR requires the changes from #815 to be merged first, as it includes necessary updates to the time module.

TODO:

  • Improve docs for the new methods with usage examples

ramon-bernardo
ramon-bernardo commented Sep 2, 2024
View reviewed changes
Copy link
Contributor Author

@ramon-bernardo ramon-bernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to conside, @udoprog

crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
@udoprog
Copy link
Collaborator

udoprog commented Sep 2, 2024

Similar issue here with constant values like in #815

udoprog
udoprog reviewed Sep 2, 2024
View reviewed changes
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
@udoprog udoprog added the enhancement New feature or request label Sep 8, 2024
@udoprog udoprog mentioned this pull request Sep 19, 2024
Merged
@udoprog udoprog changed the title Expand http module with put, delete, head, auth and more modules: Expand http module with put, delete, head, auth and more Oct 8, 2024
@ramon-bernardo
Copy link
Contributor Author

@udoprog ready for review! 😀

@ramon-bernardo ramon-bernardo marked this pull request as ready for review October 17, 2024 00:52
udoprog
udoprog requested changes Oct 17, 2024
View reviewed changes
crates/rune-modules/src/http.rs Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
crates/rune-modules/src/http.rs Outdated Show resolved Hide resolved
@udoprog udoprog mentioned this pull request Oct 29, 2024
Merged
@udoprog
Copy link
Collaborator

udoprog commented Oct 29, 2024

I added support for external constants in #860 and I was using this change as a reference. So I've re-added the constants now that it's been merged.

There were also some documentation and missing protocol implementations. In particular, when you implement a trait you also have to implement the associated protocols.

@udoprog udoprog enabled auto-merge (rebase) October 29, 2024 20:38
@udoprog udoprog merged commit c125c92 into rune-rs:main Oct 29, 2024
24 checks passed
@ramon-bernardo ramon-bernardo deleted the http-expand branch October 30, 2024 00:15
@ramon-bernardo
Copy link
Contributor Author

Thanks @udoprog, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udoprog udoprog udoprog approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-bernardo @udoprog