Simplify how variants are handled #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
force-pushed
the
simplify-variants
branch
2 times, most recently
from
84acd09
to
63ebbab
Compare
udoprog
force-pushed
the
simplify-variants
branch
from
63ebbab
to
7255277
Compare
udoprog
force-pushed
the
simplify-variants
branch
from
324ac5d
to
adcd715
Compare
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collapses all dynamic data handling into a single type which stores all data linearly in memory. It also discriminates between the values of the dynamic types (e.g. the fields) which allows for accessing RTTI without access checking. This removes a significant number of error paths and speeds up execution under some circumstances.