Fix login when running with elevated permissions from non-elevated Jagex Launcher #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvesW
changed the title
pajlada
reviewed
Mar 11, 2024
Adam-
requested changes
Mar 11, 2024
Adam-
reviewed
Mar 11, 2024
abextm
reviewed
Mar 13, 2024
src/main/java/net/runelite/launcher/JagexLauncherCompatibility.java
Outdated
Show resolved
Hide resolved
Adam-
approved these changes
Mar 13, 2024
This checks that the Jagex launcher is able to pass env variables to the client for the oauth login. If the env variables are unable to be set, the client instead asks for a RuneScape username/password which is confusing to users and will not work. Co-authored-by: YvesW <[email protected]>
Adam-
force-pushed
the
launcher-fix-jagex-launcher-login
branch
from
3d65ea4
to
bd52052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to reduce support traffic and improve user experience by detecting and fixing login problems when the user launches RL with elevated permissions via a Jagex Launcher instance that's not running with elevated permissions.
Originally PRed in #122, but dropped from that PR to split commits into separate PRs. Also swapped over to using native code instead of
reg.exeIf there are any other requested changes, feel free to let me know.