Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 5.2 #276

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Update to TypeScript 5.2 #276

merged 7 commits into from
Oct 18, 2023

Conversation

rictic
Copy link
Collaborator

@rictic rictic commented Oct 11, 2023

Drop support for TypeScript 4.4, add tests for TypeScript 4.9

Clean up dependencies and prepare to release v2.0.0

@rictic
Copy link
Collaborator Author

rictic commented Oct 11, 2023

@AndrewJakubowicz

@@ -17,9 +17,8 @@ const TS_MODULES_DEFAULT: TsModuleKind[] = ["4.0", "4.5", "4.8", "5.0", "5.1"];
function getTsModuleNameWithKind(kind: TsModuleKind | undefined): string {
// Return the corresponding ts module
switch (kind) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete nit, feel free to ignore.
Can this switch be made to fail to build if it's not exhaustively handled?

Copy link

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rictic rictic merged commit 9a21c8b into master Oct 18, 2023
8 checks passed
@rictic rictic deleted the ts5.2 branch October 18, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants