Improve options passing and default options handling (do not merge) #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this looks really nice! @tothtamas28 if you have time, it would be good to get your opinion here too. |
ehildenb
reviewed
Feb 29, 2024
ehildenb
reviewed
Feb 29, 2024
ehildenb
reviewed
Feb 29, 2024
tothtamas28
reviewed
Mar 4, 2024
…everification/evm-semantics into noah/kevm-default-options
ehildenb
reviewed
Mar 5, 2024
ehildenb
reviewed
Mar 5, 2024
…everification/evm-semantics into noah/kevm-default-options
…everification/evm-semantics into noah/kevm-default-options
…everification/evm-semantics into noah/kevm-default-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of runtimeverification/pyk#916
This is what the changes to KEVM could look like with the design in pyk#916.