-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start developing property testing #8
Conversation
82affcc
to
ffbdcd6
Compare
dc3a14a
to
e92dbfe
Compare
assert len(list(kcfg.successors(node.id))) == 0 | ||
|
||
logs: dict[int, tuple[LogEntry, ...]] = {} | ||
max_depth = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why one step at a time? Doesn't it cause an rpc call overhead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does, I think that the overhead more than 1 second / RPC call. I can change it if you think I should do it in this PR.
However, the intent of this PR was to create a basic framework for execution. It is supposed to be relatively small, in order to make it easy to review. At the same time, it is heavily biased towards debugging, since execution does not get that far anyway.
The version on which I'm working right now has a much larger depth, and it manages to finish the proof you sent me. I'm not sure how I'll split it into PRs, though, so I can't promise that max_depth will be updated in the next one.
Co-authored-by: Burak Bilge Yalçınkaya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Start developing property testing * Update the Elrond semantics * Update kmxwasm/src/kmxwasm/proofs.py Co-authored-by: Burak Bilge Yalçınkaya <[email protected]> --------- Co-authored-by: Burak Bilge Yalçınkaya <[email protected]>
No description provided.