Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start developing property testing #8

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Start developing property testing #8

merged 3 commits into from
Aug 28, 2023

Conversation

virgil-serbanuta
Copy link
Contributor

No description provided.

@virgil-serbanuta virgil-serbanuta force-pushed the foundry-like branch 2 times, most recently from 82affcc to ffbdcd6 Compare August 22, 2023 20:49
@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review August 24, 2023 11:55
assert len(list(kcfg.successors(node.id))) == 0

logs: dict[int, tuple[LogEntry, ...]] = {}
max_depth = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why one step at a time? Doesn't it cause an rpc call overhead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does, I think that the overhead more than 1 second / RPC call. I can change it if you think I should do it in this PR.

However, the intent of this PR was to create a basic framework for execution. It is supposed to be relatively small, in order to make it easy to review. At the same time, it is heavily biased towards debugging, since execution does not get that far anyway.

The version on which I'm working right now has a much larger depth, and it manages to finish the proof you sent me. I'm not sure how I'll split it into PRs, though, so I can't promise that max_depth will be updated in the next one.

kmxwasm/src/kmxwasm/proofs.py Outdated Show resolved Hide resolved
Co-authored-by: Burak Bilge Yalçınkaya <[email protected]>
Copy link
Member

@bbyalcinkaya bbyalcinkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@virgil-serbanuta virgil-serbanuta merged commit 72f5dd5 into master Aug 28, 2023
1 check passed
@virgil-serbanuta virgil-serbanuta deleted the foundry-like branch August 28, 2023 09:58
virgil-serbanuta added a commit that referenced this pull request Sep 26, 2023
* Start developing property testing

* Update the Elrond semantics

* Update kmxwasm/src/kmxwasm/proofs.py

Co-authored-by: Burak Bilge Yalçınkaya <[email protected]>

---------

Co-authored-by: Burak Bilge Yalçınkaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants