Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency: deps/kevm_release #217

Merged
merged 13 commits into from
Dec 4, 2023
Merged

Update dependency: deps/kevm_release #217

merged 13 commits into from
Dec 4, 2023

Conversation

rv-jenkins
Copy link
Collaborator

No description provided.

@palinatolmach
Copy link
Collaborator

Requires an update corresponding to the change in HASKELL_BOOSTER performed in runtimeverification/evm-semantics#2144.

@palinatolmach palinatolmach removed their assignment Nov 30, 2023
@tothtamas28 tothtamas28 self-assigned this Nov 30, 2023
@tothtamas28 tothtamas28 force-pushed the _update-deps/runtimeverification/evm-semantics branch 2 times, most recently from ebec3f7 to 51e41ce Compare December 1, 2023 09:50
@tothtamas28
Copy link
Contributor

https://github.com/runtimeverification/kontrol/actions/runs/7058406292/job/19219618587?pr=217#step:6:657

Caused by runtimeverification/evm-semantics#2194 (v1.0.376).

@anvacaru, can you look into it?

@tothtamas28 tothtamas28 assigned anvacaru and unassigned tothtamas28 Dec 1, 2023
@tothtamas28
Copy link
Contributor

https://github.com/runtimeverification/kontrol/actions/runs/7058406292/job/19214014735#step:6:768

Looks like the Booster still sends an error response on SMT failure. @geo2a, is this expected? (This is on K v6.1.34.)

@tothtamas28 tothtamas28 force-pushed the _update-deps/runtimeverification/evm-semantics branch from 44b4616 to ab308f3 Compare December 1, 2023 19:23
@palinatolmach palinatolmach self-assigned this Dec 4, 2023
@palinatolmach
Copy link
Collaborator

I updated expected output for testFailure_expect_revert, so it should fix the error in https://github.com/runtimeverification/kontrol/actions/runs/7058406292/job/19219618587?pr=217#step:6:657.

@anvacaru @tothtamas28 shall we merge it if CI passes, or do we want to wait for @geo2a's reply on Booster sending an error response on SMT failure?

@anvacaru
Copy link
Contributor

anvacaru commented Dec 4, 2023

@palinatolmach let's see the CI status at the end. Maybe the SMT error is caused by flakiness?

@tothtamas28
Copy link
Contributor

shall we merge it if CI passes

Yes, let's merge it. I added the automerge label.

@rv-jenkins rv-jenkins merged commit 91ebc71 into master Dec 4, 2023
12 checks passed
@rv-jenkins rv-jenkins deleted the _update-deps/runtimeverification/evm-semantics branch December 4, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palinatolmach palinatolmach palinatolmach approved these changes

@anvacaru anvacaru Awaiting requested review from anvacaru

Assignees

@palinatolmach palinatolmach

@anvacaru anvacaru

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rv-jenkins @palinatolmach @tothtamas28 @anvacaru