-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add av-metrics-gui-tool #290
Conversation
Can you please add some screenshots for quick view^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might require a rebase to master
Yep, I need to fix some stuff and clean up the code a bit, I'm going to work on it as soon as I can |
2bb152d
to
2f961f4
Compare
fa9446b
to
8f3a976
Compare
We can consider this PR ready. The GUI can compute video metrics on What we were not able to achieve:
Here the artifacts produced by the script: https://github.com/Luni-4/av-metrics/actions/runs/1208712639 |
I tidied up the code a bit, I think we can merge it. You can find the final release here. I will iterate over the Wasm-32 can't be run in an easy way because we have a problem with the parallelism provided by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me, apart from one comment
This PR adds
av-metrics-gui-tool
, an iced GUI tool that computes video metrics.Since the building is extremely slow due to the great amount of dependencies, for now the tool is not a workspace member, but I'm planning to add a deploy action in a following PR.
The tool also runs on web too thanks to the
WebAssembly
support provided byiced
, but it needs more in depth tests.Thanks in advance for your review!