Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for auxillary randomness #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option for auxillary randomness #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2a14f
Add option for auxillary randomness
raphjaph Oct 28, 2024
8a7c357
Add doc strings
raphjaph Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/sign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ pub fn sign_full(
if program_len != 32 {
return Err(Error::NotKeyPathSpend);
}
create_message_signature_taproot(&to_spend, &to_sign, private_key)
create_message_signature_taproot(&to_spend, &to_sign, private_key, None)
}
_ => {
return Err(Error::UnsupportedAddress {
Expand All @@ -95,7 +95,8 @@ pub fn sign_full(
to_sign.extract_tx().context(error::TransactionExtract)
}

fn create_message_signature_p2wpkh(
/// Sign for segwit inputs
pub fn create_message_signature_p2wpkh(
to_spend_tx: &Transaction,
to_sign: &Psbt,
private_key: PrivateKey,
Expand Down Expand Up @@ -143,10 +144,12 @@ fn create_message_signature_p2wpkh(
witness.to_owned()
}

fn create_message_signature_taproot(
/// Sign for taproot inputs
pub fn create_message_signature_taproot(
to_spend_tx: &Transaction,
to_sign: &Psbt,
private_key: PrivateKey,
aux_rand: Option<[u8; 32]>,
) -> Witness {
let mut to_sign = to_sign.clone();

Expand Down Expand Up @@ -175,11 +178,20 @@ fn create_message_signature_taproot(
.tap_tweak(&secp, to_sign.inputs[0].tap_merkle_root)
.to_inner();

let signature = secp.sign_schnorr_no_aux_rand(
&secp256k1::Message::from_digest_slice(sighash.as_ref())
.expect("should be cryptographically secure hash"),
&key_pair,
);
let signature = if let Some(aux_rand) = aux_rand {
secp.sign_schnorr_with_aux_rand(
&secp256k1::Message::from_digest_slice(sighash.as_ref())
.expect("should be cryptographically secure hash"),
&key_pair,
&aux_rand,
)
} else {
secp.sign_schnorr_no_aux_rand(
&secp256k1::Message::from_digest_slice(sighash.as_ref())
.expect("should be cryptographically secure hash"),
&key_pair,
)
};

let witness = sighash_cache
.witness_mut(0)
Expand Down
Loading