Do various improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a package to release on `crates.io` we don't need to include the `tests` directory or the `contrib` directory. However other config files are fine to include (they are small).
Pedantic I know. Put the `dependencies` section after then `features` in the manifest.
Add the two other coding conventions from `rust-bitcoin`.
Flesh out the rustdocs for the crate and the `Ordered` type.
This is strictly not needed because we don't have any features. But it doesn't hurt and it protects us later if we add any.
Enable the exhaustive list of the pedantic clippy lints. Allow `ptr_as_ptr` because the warning looks harmless.
Copy the current `rusntfmt` config file from `rust-bitcoin` and run the formatter.
Copy test from Rust API guidlines document to verify `Send` and `Sync` are correct.
Put the constructor method above the getters. Code move only.
tcharding
force-pushed
the
12-29-improve
branch
from
8d647dd to
3760ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done while going over the Rust API checklist in #16. Nothing too crazy here.