Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes )};{( and other fun #27

Merged
merged 5 commits into from
May 1, 2024
Merged

fixes )};{( and other fun #27

merged 5 commits into from
May 1, 2024

Conversation

bend-n
Copy link

@bend-n bend-n commented Apr 20, 2024 •
edited
Loading

i have made maybe_wrap work properly, instead of just doing string substitutions.

a

@bend-n
Copy link
Author

bend-n commented Apr 20, 2024

also this caused real problems such as syn::parse_str("fn main") not working.

danielhenrymantilla
danielhenrymantilla reviewed Apr 20, 2024
View reviewed changes
Noratrieb
Noratrieb reviewed Apr 20, 2024
View reviewed changes
@bend-n
Copy link
Author

bend-n commented Apr 21, 2024

image

ivandardi
ivandardi previously approved these changes May 1, 2024
View reviewed changes
@ivandardi
Merge branch 'main' into fix_eval
02bb56c 
Signed-off-by: Ivan Borgia Dardi <[email protected]>
ivandardi
ivandardi previously approved these changes May 1, 2024
View reviewed changes
1e1001
1e1001 reviewed May 1, 2024
View reviewed changes
@ivandardi ivandardi merged commit 54fcbd2 into rust-community-discord:main May 1, 2024
6 of 7 checks passed
@bend-n bend-n deleted the fix_eval branch May 1, 2024 05:39
ivandardi pushed a commit that referenced this pull request May 3, 2024
@bend-n
fix #27 breaking emojis (#28)
7d880b2 
so while discord renders emojis `<a:$emoji_id>` just fine poises matcher
thing does not, and therefore I sort of broke the emoji based commands.
@Noratrieb Noratrieb mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1e1001 1e1001 1e1001 left review comments

@Noratrieb Noratrieb Noratrieb left review comments

@ivandardi ivandardi ivandardi approved these changes

@danielhenrymantilla danielhenrymantilla Awaiting requested review from danielhenrymantilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bend-n @ivandardi @danielhenrymantilla @1e1001 @Noratrieb