Skip to content

Fix new clippy lints #673

Fix new clippy lints

Fix new clippy lints #673

Triggered via pull request October 29, 2023 22:24
@newAMnewAM
synchronize #490
Status Success
Total duration 37s
Artifacts

clippy.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
unsafe function's docs miss `# Safety` section: cortex-m-semihosting/src/lib.rs#L194
warning: unsafe function's docs miss `# Safety` section --> cortex-m-semihosting/src/lib.rs:194:1 | 194 | pub unsafe fn syscall1(_nr: usize, _arg: usize) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
unsafe function's docs miss `# Safety` section: cortex-m-semihosting/src/lib.rs#L188
warning: unsafe function's docs miss `# Safety` section --> cortex-m-semihosting/src/lib.rs:188:1 | 188 | pub unsafe fn syscall<T>(nr: usize, arg: &T) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
this returns a `Result<_, ()>`: cortex-m-semihosting/src/hio.rs#L35
warning: this returns a `Result<_, ()>` --> cortex-m-semihosting/src/hio.rs:35:1 | 35 | pub fn hstdout() -> Result<HostStream, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: cortex-m-semihosting/src/hio.rs#L26
warning: this returns a `Result<_, ()>` --> cortex-m-semihosting/src/hio.rs:26:1 | 26 | pub fn hstderr() -> Result<HostStream, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: cortex-m-semihosting/src/hio.rs#L14
warning: this returns a `Result<_, ()>` --> cortex-m-semihosting/src/hio.rs:14:5 | 14 | pub fn write_all(&mut self, buffer: &[u8]) -> Result<(), ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/