Skip to content

semihosting: add Safety docstring to syscall #674

semihosting: add Safety docstring to syscall

semihosting: add Safety docstring to syscall #674

Triggered via pull request October 29, 2023 22:49
@newAMnewAM
opened #491
Status Success
Total duration 29s
Artifacts

clippy.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
this returns a `Result<_, ()>`: cortex-m-semihosting/src/hio.rs#L35
warning: this returns a `Result<_, ()>` --> cortex-m-semihosting/src/hio.rs:35:1 | 35 | pub fn hstdout() -> Result<HostStream, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: cortex-m-semihosting/src/hio.rs#L26
warning: this returns a `Result<_, ()>` --> cortex-m-semihosting/src/hio.rs:26:1 | 26 | pub fn hstderr() -> Result<HostStream, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
this returns a `Result<_, ()>`: cortex-m-semihosting/src/hio.rs#L14
warning: this returns a `Result<_, ()>` --> cortex-m-semihosting/src/hio.rs:14:5 | 14 | pub fn write_all(&mut self, buffer: &[u8]) -> Result<(), ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default
needless `fn main` in doctest: cortex-m-semihosting/src/debug.rs#L12
warning: needless `fn main` in doctest --> cortex-m-semihosting/src/debug.rs:12:4 | 12 | //! use cortex_m_semihosting::debug::{self, EXIT_SUCCESS, EXIT_FAILURE}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main = note: `#[warn(clippy::needless_doctest_main)]` on by default
manual slice size calculation: cortex-m/src/peripheral/scb.rs#L755
warning: manual slice size calculation --> cortex-m/src/peripheral/scb.rs:755:13 | 755 | slice.len() * core::mem::size_of::<T>(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::mem::size_of_val(slice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation
manual slice size calculation: cortex-m/src/peripheral/scb.rs#L669
warning: manual slice size calculation --> cortex-m/src/peripheral/scb.rs:669:13 | 669 | slice.len() * core::mem::size_of::<T>(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::mem::size_of_val(slice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/